glideapps / glide-data-grid

🚀 Glide Data Grid is a no compromise, outrageously react fast data grid with rich rendering, first class accessibility, and full TypeScript support.
https://grid.glideapps.com
MIT License
4.07k stars 301 forks source link

onCellEdited fires for readonly cols when getCellsForSelection is set to true #987

Open vydimitrov opened 3 months ago

vydimitrov commented 3 months ago

Hello all, I just noticed that onCellEdited fires for readonly cols when getCellsForSelection is set to true. It seems the bug was introduced with version 6 since I was not able to reproduce it on version 5.

Steps to reproduce it:

You can reproduce it here as well: https://codesandbox.io/p/sandbox/lingering-glitter-xzj2fz?file=%2Fsrc%2FApp.tsx%3A62%2C2

If you remove/comment getCellsForSelection then onCellEdited doesn't fire and it works as expected.

I'd expect that onCellEdited won't fire since the column is read only.