search

glideapps / quicktype

Generate types and converters from JSON, Schema, and GraphQL
https://app.quicktype.io
Apache License 2.0
11.75k stars 1.03k forks source link

Many warnings in multiFileOutput #2437

Open relet opened 7 months ago

relet commented 7 months ago

Would it be acceptable to filter them, or is that hiding important information?

if (this._finishedFiles.has(filename) && !this._options.multiFileOutput) {

instead of

https://github.com/glideapps/quicktype/blob/55dc6a7912715b7db45419958bf89d00637cd4cd/packages/quicktype-core/src/Renderer.ts#L308

inferrinizzard commented 1 month ago

Hi @relet , could you provide some context on what specific warnings you are seeing ?

relet commented 1 month ago

The warning mentioned in the code

            `[WARNING] Tried to emit file ${filename} more than once. If performing multi-file output this warning can be safely ignored.`

I don't remember exactly what I was seeing, but if you explicitly select multi-file output, it would be sufficient to show it once (if there really is anything to warn about) or suppress it if it can be ignored.