search

glideapps / quicktype

Generate types and converters from JSON, Schema, and GraphQL
https://app.quicktype.io
Apache License 2.0
11.79k stars 1.04k forks source link

CI Fix - Updated Newtonsoft.Json csharp library to 13.0.3 #2493

Closed jambyung closed 5 months ago

jambyung commented 5 months ago

Due to breaking change The jsonString at /test/utils.ts:237 contains error message value like following, which causes JSON.parse(jsonString) to throw error

/Users/xxxxx/proj/quicktype/test/runs/schema-csharp-390aed/test.csproj : warning NU1903: Package 'Newtonsoft.Json' 10.0.3 has a known high severity vulnerability, https://github.com/advisories/GHSA-5crp-9r3c-p9vr

Simply updating the library to newer version solved the issue for now, but in future similar issue can happen again if new security issue is found.

dvdsgl commented 5 months ago

Thank you!