glideapps / quicktype

Generate types and converters from JSON, Schema, and GraphQL
https://app.quicktype.io
Apache License 2.0
11.76k stars 1.04k forks source link

fix: punycode error for non CI #2587

Open avallete opened 2 months ago

avallete commented 2 months ago

Description

Following #2581

This PR fixed an issue with CI but re-introduced the issue with the warning for node >= 21 because instead of conditionally importing the cross-fetch deps only if needed, it was importing it at the top of the file (so that was executed at file load whatever the context).

This PR reinstate the #2573 fix, but keep also keep the "CI fix" around.

Related Issue

Motivation and Context

Previous Behaviour / Output

New Behaviour / Output

How Has This Been Tested?

Screenshots (if appropriate):