Closed mmascher closed 2 years ago
I was also worried about performances, but I did not see any change in the memory usage charts:https://snapshots-origin.grafana.net/dashboard/snapshot/zYf6xB5iiKTP4st67i2qAcsbvVuWa5E6?orgId=2&refresh=1m I installed the factory on the 14th/15th of June and applied the fix right after.
Anyway, the changes you are proposing makes a lot of sense! I did not think of converting the regexp to bytes.
I opened a new PR since the changes here do not make sense anymore: https://github.com/glideinWMS/glideinwms/pull/165 Should we close this one and start over from the new one?
I was also worried about performances, but I did not see any change in the memory usage charts:https://snapshots-origin.grafana.net/dashboard/snapshot/zYf6xB5iiKTP4st67i2qAcsbvVuWa5E6?orgId=2&refresh=1m I installed the factory on the 14th/15th of June and applied the fix right after.
Anyway, the changes you are proposing makes a lot of sense! I did not think of converting the regexp to bytes.