search

glideinWMS / glideinwms

The glideinWMS Project
http://tinyurl.com/glideinwms
Apache License 2.0
16 stars 46 forks source link

Fix exception duting completed stats computation. Fixes #155 #165

Closed mmascher closed 2 years ago

mmascher commented 2 years ago

I see we have a dir named unittests/fixtures/factory/log/client/ in the repo. It is empty. Is it supposed to contain glidein logfiles that can be used for unit tests? I was thinking of adding a real(production) glidein stdout logfile and adding a unit test.

mmascher commented 2 years ago

I just closed https://github.com/glideinWMS/glideinwms/pull/160 that preceeded this one.

mambelli commented 2 years ago

Changers satisfy the suggestions in PR #160. unittests/fixtures/factory/log/client/ and a subdirectory under it are the right directory for the log file as discussed in the meeting today. Waiting for the unit test before approving and merging.

mmascher commented 2 years ago

@mambelli I added the unit test

mambelli commented 2 years ago

There is a problem with one unit test: test_lib_symCrypto.py detected strings improperly converted from bytes

mmascher commented 2 years ago

@mambelli I run the test on my machine and I could not replicate the issue. Could it be related to a different version of the system m2crypto library? I have '0.35.2' on my machine.

I see the output of the unit test is saved here output/gwms.LOCAL.pyunittest.d/gwms.LOCAL.pyunittest.d.test_lib_symCrypto.txt but I could not find out how to access it. Can you help me? :)