Modularization and cleaning of the glidein_startup.sh script - Githubissues

glideinWMS / glideinwms

The glideinWMS Project

http://tinyurl.com/glideinwms

Apache License 2.0

16 stars 46 forks source link

Modularization and cleaning of the glidein_startup.sh script #197

Open terranovafr opened 2 years ago

terranovafr commented 2 years ago

In this pull request, I attach the current evolving draft of the modularization and cleaning of the glidein_startup.sh script. Division in modules:

glidein_startup.sh: revised and reduced
glidein_cleanup.sh: functions regarding the glidein termination and cleanup
utils_.sh: utility functions regarding (crypto, io, signals, tarballs, params, xml)
utilsgs.sh: utility functions specific for the glidein_startup regarding (filesystem, http, io, signals, tarballs)

Most relevant modifications:

local scope of some variables which were global but used only in that function
definition of the create_xml function for creating xml strings and print_header_line for printing header strings
grouped some code blocks in functions
added comments explaining for each function the arguments, global variables used, the returned values and the environment

mambelli commented 2 years ago

Better rebase os this PR: https://github.com/mambelli/glideinwms/pull/12