search

glideinWMS / glideinwms

The glideinWMS Project
http://tinyurl.com/glideinwms
Apache License 2.0
16 stars 46 forks source link

Fixed exit code inconsistency when using tokens and made code more robust #216

Closed mambelli closed 2 years ago

mambelli commented 2 years ago

Fixed exit code inconsistency when using tokens and made code more robust

Exit code consistent w/ erro_gen XML, restored check on needed condor variables and fixed x509 conditional checks, made compliant w/ new gconfig_add/get, linting improvements

mambelli commented 2 years ago

Thanks, I fixed the bug. The previous create_mapfile.sh code had

config_file="$1"
glidein_config="$1"  # TODO: why this? For some sourced file?

I removed the second line not understanding the need. The crash would have been there also w/ the previous add_config_line.

add_config_line() already required $glidein_config to be defined in the environment, which is not the best choice for an API. I added also a note on top of add_config_line.source, to report in the documentation. I'm wondering if I should make a new function gconfig_set() where the first parameter has to be the file name. Changing the invocation of add_config_line or gconfig_add would be even more confusing. What do you think? Should we open an issue about it?

Existing scripts w/ a different config file name use only gconfig_get which takes the file name as optional second command line parameter.