glideinWMS / glideinwms

The glideinWMS Project
http://tinyurl.com/glideinwms
Apache License 2.0
16 stars 45 forks source link

Frontend reporting wrong monitoring numbers aka credential ID in Glideins not set for scitokens #242

Closed mambelli closed 1 year ago

mambelli commented 1 year ago

Describe the bug When using scitokens (either on entries w/ scitoken authentications or on entries with grid_proxy in non-hybrid mode), the Frontend is reporting all 0 in the monitoring values about running glideins in the glideclient classad, which are used for the Factory monitoring.

To Reproduce Install a token-only setup

Expected behavior Report correctly ass idle and running glideins

Screenshots If applicable, add screenshots and/or console outputs to help explain your problem.

Info (please complete the following information):

Additional context I did some troubleshooting. This happens because the Factory is not setting a credential ID when submitting Glideins w/ scitokens (OK for proxy, ssh keys, ...). The credential ID is what is used by the Frontend to recognize the Glidiens belonging to a certain request and submitted w/ a credential.

def getClientCondorStatusCredIdOnly(status_dict, cred_id):
...
            lambda el: ("GLIDEIN_CredentialIdentifier" in el and (el["GLIDEIN_CredentialIdentifier"] == cred_id)),
...

The use of generated credentials is complicating the problem (these are not available a priori like all other credentials)

mambelli commented 1 year ago

PR #243 fixes this bug and contains also patching instructions for GlideinWMS 3.9.6 (https://github.com/glideinWMS/glideinwms/pull/243#issuecomment-1327636652)