glideinWMS / glideinwms

The glideinWMS Project
http://tinyurl.com/glideinwms
Apache License 2.0
16 stars 46 forks source link

RRD fetch failing in the factory #351

Closed mambelli closed 1 year ago

mambelli commented 1 year ago

Describe the bug RRD fetch failing in the Factory with exceptions visible in the log file

To Reproduce Running the Factory you see:

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/glideinwms/factory/glideFactoryMonitoring.py", line 1496, in fetchData
    fetched = baseRRDSupport.fetch_rrd(pathway + rrd_file, "AVERAGE", resolution=res, start=start, end=end)
  File "/usr/lib/python3.6/site-packages/glideinwms/lib/rrdSupport.py", line 471, in fetch_rrd
    raise RuntimeError(f"Error when running rrdtool.fetch") from e
RuntimeError: Error when running rrdtool.fetch
[2023-09-14 06:18:39,203] DEBUG: glideFactoryMonitoring:1500: Failed to load /var/lib/gwms-factory/work-dir/monitor/entry_CMSHTPC_T1_DE_KIT_htcondor-ce-1-kit/frontend_CMSG-v1_0_cmspilot/Status_Attributes.rrd
[2023-09-14 06:18:39,203] ERROR: glideFactoryMonitoring:1499: MMM
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/glideinwms/lib/rrdSupport.py", line 469, in fetch_rrd
    return self.rrd_obj.fetch(filename)
rrdtool.OperationalError: Usage: rrdtool fetch <file> <CF> [options]

Provided by @jdost321 and @mmascher

Expected behavior This is a consequence of PR #339 The fetch call should be: return self.rrd_obj.fetch(*args) instead of return self.rrd_obj.fetch(filename). During the review, this line was changed as well instead of only the exception handling.

Screenshots NA

Info (please complete the following information): Stakeholders and components can be a comma-separated list or on multiple lines. If you add a new stakeholder or component, not on the sample list, add it on a line by its own.

Additional context Add any other context or supporting files about the problem here.