Note: This is a patch fix for the prevention mechanism (PR #415) that was added to the blackhole detection mechanism in #331.
TLDR;
PR #415 introduced a bug which resulted in the prevention mechanism to be effective only when the blackhole detection feature was not enabled (via the frontend configuration). When blackhole detection was necessary (aka, enabled), the prevention mechanism still continued to determine that blackhole detection was not needed, when in actual it should be needed. Turns out this was caused as a result of using the wrong case of the variable name involved in the determination logic. Specifically, the variable name should have been glidein_blackhole_rate (shell variable name in the context of condor_startup.sh) instead of GLIDEIN_BLACKHOLE_RATE (which is a frontend knob and is read from glidein_config).
Fixes #415.
Note: This is a patch fix for the prevention mechanism (PR #415) that was added to the blackhole detection mechanism in #331.
TLDR; PR #415 introduced a bug which resulted in the prevention mechanism to be effective only when the blackhole detection feature was not enabled (via the frontend configuration). When blackhole detection was necessary (aka, enabled), the prevention mechanism still continued to determine that blackhole detection was not needed, when in actual it should be needed. Turns out this was caused as a result of using the wrong case of the variable name involved in the determination logic. Specifically, the variable name should have been
glidein_blackhole_rate(shell variable name in the context of condor_startup.sh) instead ofGLIDEIN_BLACKHOLE_RATE(which is a frontend knob and is read fromglidein_config).