search

gliderlabs / logspout

Log routing for Docker container logs
MIT License
4.66k stars 680 forks source link

supporting containerd directly? (Feature request) #498

Open CoreTechnologyAG opened 3 years ago

CoreTechnologyAG commented 3 years ago

Hello

We use logspout in our docker infrastructure. Now we are planning to switch to kubernetes based on containerd. Kubernetes doesn't support dockerd anymore in the future.

Is there a plan to migrate/enhance logspout to this? Thanks

michaelshobbs commented 3 years ago

Due to lack of development time, this project has pretty much gone into maintenance mode. However, I am certainly open to guiding and reviewing a PR to achieve this goal.

onpaws commented 3 years ago

We use logspout and like it in part b/c of its smaller resource footprint compared to other things out there. Would you be able to please suggest any spiritually similar alternatives?

merowing1279 commented 2 years ago

@michaelshobbs are you working on it or can I take this task?

michaelshobbs commented 2 years ago

@merowing1279 please by all means feel free to take this. let me know if i can offer any insight or assistance

merowing1279 commented 2 years ago

ok :) what I'm understanding here is to use instead of docker socket the containerd socket and asking about log the containerd API. Am I right?

michaelshobbs commented 2 years ago

sounds right to me? we also need to sort out how we will test and (maybe?) potentially fallback to the previous functionality. if we don't want to do that then we at least need to document the bare minimum docker/containerd version we support after this change.

merowing1279 commented 2 years ago

I'm thinking to have the both working version. I will try to prepare a good interface for hiding the type of runtime implementation which is using during starting the logspout.

michaelshobbs commented 2 years ago

sounds good to me

merowing1279 commented 2 years ago

@CoreTechnologyAG are you still waiting for this feature?

CoreTechnologyAG commented 2 years ago

No we don't need this feature anymore. We switched to filebeat from elastic

karlvr commented 1 year ago

@merowing1279 did you make any progress on this? We are considering the switch to containerd and currently use a derivative of this container.

merowing1279 commented 1 year ago

@karlvr you can go with containerd.

rhaex commented 8 months ago

@karlvr you can go with containerd.

Do you mean that the current logspout version works with containerd as well? Or do we need a special version of it? Could you elaborate a bit more? Thanks!