Fails to build due to changes upstream

gliderlabs / registrator

Service registry bridge for Docker with pluggable adapters

http://gliderlabs.com/registrator

MIT License

4.66k stars 912 forks source link

Fails to build due to changes upstream #591

Open braddeicide opened 7 years ago

braddeicide commented 7 years ago

This change: https://github.com/ugorji/go/commit/54210f4e076c57f351166f0ed60e67d3fca57a36

Causes go-etcd to fail to compile, I've created a PR https://github.com/coreos/go-etcd/pull/250. To work around for now you can add the following to patch go-etcd before compiling registrator.

go get -u github.com/ugorji/go/codec/codecgen go get -u github.com/coreos/go-etcd/etcd cd /go/src/github.com/coreos/go-etcd/etcd /go/bin/codecgen -d 1978 -o response.generated.go response.go

nwbt commented 7 years ago

Same issue. Could you go into a bit more detail on how to workaround the issue? Cheers!

Never mind. Very helpful information @braddeicide provided above, thanks!