cleanup doesn't remove duplicate entries

gliderlabs / registrator

Service registry bridge for Docker with pluggable adapters

http://gliderlabs.com/registrator

MIT License

4.66k stars 913 forks source link

cleanup doesn't remove duplicate entries #622

Open CpuID opened 6 years ago

CpuID commented 6 years ago

v7, latest official build (with a wrapper bash script). See https://github.com/gliderlabs/registrator/issues/621 for our topology/versions etc.

If you use -cleanup, registrator doesn't detect the same ServiceID/Address/Port combination multiple times, and cull duplicates. I managed to get duplicates by restarting registrator, and it added new entries without removing the old ones :(

CpuID commented 6 years ago

Entirely possible that https://github.com/gliderlabs/registrator/pull/433 would have avoided the duplicates in the first place...

nmartinez-nimeops commented 5 years ago

hi, fix coming soon? :D