gliderlabs / registrator

Service registry bridge for Docker with pluggable adapters
http://gliderlabs.com/registrator
MIT License
4.66k stars 912 forks source link

Support for newer versions of Consul #680

Closed yacinelazaar closed 4 years ago

yacinelazaar commented 4 years ago

Howdy,

Was wondering if there are any plans to support later versions of Consul for this project?

Thanks.

mrwacky42 commented 4 years ago

How much later? Is there a particular feature that does not work?

yacinelazaar commented 4 years ago

Hey, thanks for reaching back. Would like to use Consul's service mesh (Consul Connect) but couldn't make the registrator work with official Consul images and had to rely on gliderlas's server and agent images to make service discovery work. Perhaps I misconfigured something but I had to be sure. Is it the only way the registrator is meant to work?

mrwacky42 commented 4 years ago

Interesting, I don't use Consul Connect (yet), but I want to start soon.

yacinelazaar commented 4 years ago

Well, Is the registrator coupled to gilderlabs server/agent images?

OneCricketeer commented 4 years ago

It is not. What part of the docs say that it would be?

larssb commented 4 years ago

Allow me to chirp in here. Also properties for health checks like:

are not supported as far as I can see. Would be great to have as well. And can anyone tell me the syntax for registering a health check in newer version of Consul 1.7.0+ .... where it is a script check. Like described here: https://gliderlabs.github.io/registrator/latest/user/backends/ under Consul Script Check. I can't get it to work.

Thank you

OneCricketeer commented 4 years ago

We use curl as our basic health checks in containerpilot, and it works fine

That'd be your alternative to registrator

yacinelazaar commented 4 years ago

@larssb I managed to get the registrator to work with Consul 1.7. My first trial failed and every example out there uses images managed by gliderlabs so I assumed that was the way to go.

larssb commented 4 years ago

Nice stuff @yacinelazaar .... but I will still miss the opportunity to set e.g. the Consul health check properties I mention.

OneCricketeer commented 4 years ago

I'm not quite sure I understand y'all's problem

I can't get it to work. — @larssb

Could you please show a SSCCE?