gliff-ai / curate

gliff.ai CURATE – a user-friendly browser interface for curating large multidimensional image datasets for machine learning development
https://gliff.ai
GNU Affero General Public License v3.0
2 stars 0 forks source link

fix: redness #375

Closed philipjackson closed 2 years ago

philipjackson commented 2 years ago

Description

Mixes RGB channels when creating thumbnails so they're no longer red.

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts and fixes 1 when merging f8bd6e2ea91aba03366b1dba327fc889ae436d25 into dfa0445e1c55fb2ef779a35de0f5844d9be1687c - view on LGTM.com

new alerts:

fixed alerts:

github-actions[bot] commented 2 years ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-375.westeurope.azurestaticapps.net

philipjackson commented 2 years ago

Is there some sort of test we can add? Also, does this need changing in ANNOTATE too as that was also red for me?

There's a separate issue for ANNOTATE that fixes the lack of green and blue channels there. Giving up on the test for now since there seems to be no way to use ImageBitmap in Jest/jsdom, and we can't test this code meaningfully without that. A selenium/Percy test for basic things like uploading an image and opening it in ANNOTATE would make more sense, if we can make it work stably. I'll make an issue for it.