feat: nicer datatable - Githubissues

gliff-ai / curate

gliff.ai CURATE – a user-friendly browser interface for curating large multidimensional image datasets for machine learning development

https://gliff.ai

GNU Affero General Public License v3.0

2 stars 0 forks source link

feat: nicer datatable #424

Closed cooper667 closed 2 years ago

cooper667 commented 2 years ago

Description

Minor datatable changes, addresses some of https://github.com/gliff-ai/curate/issues/417 (which i only saw after doing them...it doesn't aim to solve all the points in that issue, just some of the easy wins/obviously broken parts)

It now works with sort/filter on the side bar (and removes those options from the columns)
Add some small typings
Move DataTable into new file to make ui.tsx very slightly neater
Hide 'multiselect' button when on table view
Disable thumbnail size on table view
minor polish on sort popover

One thing that isn't supported in DataTable is groupBy unless we give MUI the dollars. Not sure if we need a way in the UI to indicate that @joshuajames-smith ?

Created 2 follow on issues:

https://github.com/gliff-ai/curate/issues/423 https://github.com/gliff-ai/curate/issues/422

github-actions[bot] commented 2 years ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 40b7ec4db21df268dd0f61ec354ba137b779d573 into 6e366cf86569950b6b70ec83456129baf0493119 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

github-actions[bot] commented 2 years ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 2f5479562d2f1ef4e6e62ce43d506d747b9d41a1 into 5dd4641c79f18327e3143e21c8924a5a6f7ae0e1 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

github-actions[bot] commented 2 years ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

github-actions[bot] commented 2 years ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-424.westeurope.azurestaticapps.net

cooper667 commented 2 years ago

No percy?

joshuajames-smith commented 2 years ago

One thing that isn't supported in DataTable is groupBy unless we give MUI the dollars. Not sure if we need a way in the UI to indicate that @joshuajames-smith ?

@cooper667 we can just disabled or remove the checkbox to groupBy in the sort dialogue?