By default, django makes a new SQL connection for every database query it makes. This is a legacy thing; django 2 had to be this way, but we're on django 4 now. Setting CONN_MAX_AGE to None keeps the database connection open indefinitely, and this reduces query times from 0.5-0.7s to 0.02s. We should probably set it to something other than None in the future though, to prevent dead connections from piling up.
Checklist:
Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!
[ ] I have read the gliff.ai Contribution Guide.
[ ] I have requested to pull a branch and not from main.
[ ] I have checked all commit message styles match the requested structure.
[ ] My code follows the style guidelines of this project.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have performed a self-review of my own code.
[ ] I have assigned 3 or less reviewers.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] My changes generate no new warnings.
[ ] I have made corresponding changes to the documentation.
[ ] New database changes have been committed.
[ ] If appropriate, I have bumped any version numbers.
Description
By default, django makes a new SQL connection for every database query it makes. This is a legacy thing; django 2 had to be this way, but we're on django 4 now. Setting
CONN_MAX_AGEtoNonekeeps the database connection open indefinitely, and this reduces query times from 0.5-0.7s to 0.02s. We should probably set it to something other thanNonein the future though, to prevent dead connections from piling up.Checklist:
Put an
xin the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!