Fixes & optimizations - Githubissues

gliffy / canvas2svg

Translates HTML5 Canvas draw commands to SVG

MIT License

691 stars 157 forks source link

Fixes & optimizations #66

Open mudcube opened 6 years ago

mudcube commented 6 years ago

This pull request:

Greatly reduces garbage during exports, improving export time.
Fixes error thrown with font_names with underscores
Fixes error when HTMLCanvasElement pattern is sent to C2S instance
Adds fill-rule support as reported in issue #62
Merges in opacity support for issue #53

jods4 commented 6 years ago

I tried this patch because the fill=evenodd bug hit me hard.

I can confirm that the evenodd fix works.

Unfortunately I also have to report that some of the other optimisations broke other stuff, I get funny results that were previously ok.

mudcube commented 6 years ago

Hey jods, what new issues are you noticing with this pull request? Perhaps I can sort them out if you give me some detailed instructions to reproduce.

On Sun, Jun 3, 2018, 11:44 AM jods notifications@github.com wrote:

I tried this patch because the fill=evenodd bug hit me hard.

I can confirm that the evenodd fix works.

Unfortunately I also have to report that some of the other optimisations broke other stuff, I get funny results that were previously ok.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gliffy/canvas2svg/pull/66#issuecomment-394182503, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGMvOnmhGKR0frkC3vQfK0acdwfu-Rxks5t5C6KgaJpZM4SjoX_ .

jods4 commented 6 years ago

@mudcube in my document many lines end up at the origin after your patch, they were drawn correctly before.

Unfortunately it's real documents with around 10K calls to context, that I cannot easily share or reduce.

That said, some tests are currently falling, could that be related? I can gladly retest my docs when they are fixed.

mudcube commented 6 years ago

@jods4 The transformation issue should be sorted out, let me know if you're still running into the issue. There's still a couple failing tests, but part of that is due to slight formatting changes (ex. spacing), and doesn't actually affect what's visually exported.

jods4 commented 6 years ago

@mudcube I tried again and the "all lines go to origin" problem is fixed on your master.

But it's not completely fixed. Paths are now at their correct position, but they are way too wide. There is still a regression inside that PR.