glific / glific-frontend

Frontend for the Glific platform
https://glific.org
GNU Affero General Public License v3.0
35 stars 37 forks source link

Feature: Template flows #2975

Closed akanshaaa19 closed 1 month ago

github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-2975--glific-frontend.netlify.app

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (af1cb04) to head (2a6e084).

Files Patch % Lines
src/containers/Flow/FlowList/FlowList.tsx 77.41% 6 Missing and 1 partial :warning:
src/components/floweditor/FlowEditor.tsx 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2975 +/- ## ========================================== + Coverage 80.00% 80.15% +0.15% ========================================== Files 320 320 Lines 10236 10302 +66 Branches 2183 2201 +18 ========================================== + Hits 8189 8258 +69 + Misses 1398 1397 -1 + Partials 649 647 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 1 month ago

2 failed tests on run #5017 ↗︎

2 172 0 0 Flakiness 0

Details:

Merge 2a6e08425598f054ac23aafc68f7bf9f62954d5d into af1cb04aef390ce9b04e16b20196...
Project: Glific Commit: 68bb7fd3a2 ℹ️
Status: Failed Duration: 26:53 💡
Started: Jul 23, 2024 8:15 AM Ended: Jul 23, 2024 8:42 AM
Failed  cypress/e2e/flow/Flow.spec.ts • 2 failed tests View Output
Test Artifacts
Flow > should load Flow list Test Replay Screenshots
Flow > sorting by title should work perfectly Test Replay Screenshots

Review all test suite changes for PR #2975 ↗︎

akanshaaa19 commented 1 month ago
  1. Ideally view it should directly open the flow. What would opening the flow in edit mode achieve.
Screenshot 2024-07-15 at 4 39 40 PM
  1. Lets call the menu item templates since we are already inside flows.
Screenshot 2024-07-15 at 4 38 33 PM

on view it we will show description about the template flow thats why it takes to edit page first