glific / mobile

8 stars 17 forks source link

feat: added login authentication popup message #131

Closed ajaman190 closed 1 year ago

ajaman190 commented 1 year ago

Description: This pull request addresses the issue #87, "Create login Screen Pop up on validating authentication."

Changes Made:

  1. Added a custom popup component to handle success and error alerts during the login process.
  2. Removed the Notification tab from the side drawer for a cleaner user interface.

Screenshots:

https://github.com/glific/mobile/assets/84832565/4f8b5044-5557-4845-b503-2421c89f6a3c

Closes Issue: Closes #87

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 10.00% and project coverage change: -0.39 :warning:

Comparison is base (47a503e) 64.18% compared to head (898c512) 63.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ========================================== - Coverage 64.18% 63.79% -0.39% ========================================== Files 65 69 +4 Lines 952 986 +34 Branches 78 80 +2 ========================================== + Hits 611 629 +18 - Misses 323 339 +16 Partials 18 18 ``` | [Impacted Files](https://app.codecov.io/gh/glific/mobile/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific) | Coverage Δ | | |---|---|---| | [components/ui/PopupAlert.tsx](https://app.codecov.io/gh/glific/mobile/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific#diff-Y29tcG9uZW50cy91aS9Qb3B1cEFsZXJ0LnRzeA==) | `0.00% <0.00%> (ø)` | | | [config/apollo.ts](https://app.codecov.io/gh/glific/mobile/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific#diff-Y29uZmlnL2Fwb2xsby50cw==) | `0.00% <0.00%> (ø)` | | | [screens/Login.tsx](https://app.codecov.io/gh/glific/mobile/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific#diff-c2NyZWVucy9Mb2dpbi50c3g=) | `77.55% <100.00%> (+2.55%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/glific/mobile/pull/131/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.