glific / mobile

8 stars 17 forks source link

Added server url suffix in env and handle large number of subscriptions #168

Closed ajaman190 closed 1 year ago

ajaman190 commented 1 year ago

Description

This PR will address the issue mention in #167

Changes Made

Screenshots

--

Related Issues

Closes: #167 Closes: #160

@mdshamoon Kindly review this PR.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.46% and project coverage change: -0.48% :warning:

Comparison is base (9778709) 70.27% compared to head (dd85935) 69.80%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #168 +/- ## ========================================== - Coverage 70.27% 69.80% -0.48% ========================================== Files 93 94 +1 Lines 1514 1530 +16 Branches 139 142 +3 ========================================== + Hits 1064 1068 +4 - Misses 405 415 +10 - Partials 45 47 +2 ``` | [Files Changed](https://app.codecov.io/gh/glific/mobile/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific) | Coverage Δ | | |---|---|---| | [config/index.ts](https://app.codecov.io/gh/glific/mobile/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific#diff-Y29uZmlnL2luZGV4LnRz) | `50.00% <50.00%> (ø)` | | | [screens/Chat.tsx](https://app.codecov.io/gh/glific/mobile/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific#diff-c2NyZWVucy9DaGF0LnRzeA==) | `69.62% <60.52%> (-10.38%)` | :arrow_down: | | [screens/Server.tsx](https://app.codecov.io/gh/glific/mobile/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glific#diff-c2NyZWVucy9TZXJ2ZXIudHN4) | `90.00% <66.66%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ajaman190 commented 1 year ago

Tested it on my local. This doesn't seem to work for me. The value from env is not loaded on the organization URL page.

Can you try it once on your end and see if everything looks good

Tried after clearing the cache, it is working fine.