glifio / safe

A Filecoin multisig wallet
https://safe.glif.io
1 stars 0 forks source link

Improve admin page design #50

Closed navFooh closed 2 years ago

navFooh commented 2 years ago

Hey @navFooh is there a reason you replaced the calls to navigate with router.push?

I know the navigate function doesn't add anything rn, but if we have query params that we want to persist in the future (like a setting or a network), it's nice to use the navigate func since we can keep persisted query params

Not sure if i'm missing something with the change away from navigate tho

Hey, yeah the reason I used router.back() was just because I thought that navigate didn't add anything useful here, bu I see the value in keeping it for future purposes