gligli / p600fw

Teensy++ based Sequential Circuits Prophet 600 firmware remake
http://gligli.github.io/p600fw/
41 stars 23 forks source link

Commit 1184ae introduced bug in chord memory function #29

Closed polluxsynth closed 10 years ago

polluxsynth commented 10 years ago

After commit 1184aeb35794a0f7ac1b5c9662d4e1ff38451a59 the chord memory function doesn't work properly. When holding the chord and switching to unison mode, they voices are not silenced as they should be, and after releasing the keys most often one of the voices hangs (i.e. is not gated off). The actual chord memory function works as expected, i.e. pressing a single key results in the programmed chord to be heard, however, if there are still available voices the drone from the hanging voice still remains.

gligli commented 10 years ago

6d3af6aa91b44873053ba6d550244a25f2ccd6c0 should fix it!

polluxsynth commented 10 years ago

Yes, that seems to fix it. Thanks!