Uncomment tuningName to fix DEBUG build

gligli / p600fw

Teensy++ based Sequential Circuits Prophet 600 firmware remake

http://gligli.github.io/p600fw/

41 stars 23 forks source link

Closed snickell closed 9 years ago

snickell commented 9 years ago

The #define DEBUG build was broken when I commented out a variable name used in debug print messages. This fixes the build when DEBUG=1.

gligli commented 9 years ago

Yeah, but this leaves a warning in normal compilation. Maybe it should be surrounded by a #ifdef

snickell commented 9 years ago

sorry about that, PR updated to remove warning.

The PR also now enables -Werror to avoid future committers suggesting code with warnings. Does -Werror make sense to you for this project?

gligli commented 9 years ago

Werror may be a bit overkill but yeah, It's nicer when the code compiles with no warnings.

snickell commented 9 years ago

Removed -Werror, should be ready to merge now.

gligli commented 9 years ago

Thanks!