search

glihm / starknet-abigen-rs

Exploratory work on abigen in rust for Starknet 🦀
Apache License 2.0
15 stars 1 forks source link

update types into Uppercases #21

Open rkdud007 opened 1 year ago

rkdud007 commented 1 year ago

Right now we use lowercase to 1) Cairo type representation in Rust 2) Original Rust type in uint, int, bool. But I think it's not good practice to have exact same name with original rust type. Maybe we can use remco/uint to Cairo type in Rust as uppercase struct ( Alloy did same approach ).

reference

https://github.com/alloy-rs/core/blob/main/crates/dyn-abi/src/resolve.rs

glihm commented 1 year ago

Sounds like a nice idea @rkdud007! Let's get this then. :)