search

glimmerjs / glimmer-application-pipeline

Tooling for developing Glimmer standalone apps with ember-cli
MIT License
21 stars 31 forks source link

support generating `<Capital />` component names #129

Closed GavinJoyce closed 6 years ago

GavinJoyce commented 6 years ago

adds support for generating <Capital /> component names: https://emberjs.com/blog/2017/10/10/glimmer-progress-report.html#toc_adopting-code-capital-code-components

screen shot 2017-10-11 at 22 07 00 screen shot 2017-10-11 at 22 06 28 screen shot 2017-10-11 at 21 47 07

(I think the yellow warnings are due to the fact that I'm pointing to a github branch)

/cc @tomdale @rwjblue

rwjblue commented 6 years ago

Awesome, thank you @GavinJoyce!

cibernox commented 6 years ago

Are the files on the disk expected to be also capitalized? My understanding was that although components might be capitalized now, the files should still use kebab-case

rwjblue commented 6 years ago

there is no normalization in play, therefore the files on disk are exactly the same as how they are invoked

cibernox commented 6 years ago

And there will be at some point? Probably it's because of habit, but seeing capitalized files makes me cringe.

rwjblue commented 6 years ago

there is no normalization in play

And there will be at some point?

I doubt it, runtime normalization is just more work we have to do for each instance/lookup/etc and we would prefer to avoid it.

Probably it's because of habit, but seeing capitalized files makes me cringe.

Yep, I had the same initial reaction.

webark commented 6 years ago

ya, case sensitive files seems like a recipe for disaster. (especially since how a drive is formatted, file name case sensitivity isn’t always enabled, or tracked)