search

glimmerjs / glimmer-application-pipeline

Tooling for developing Glimmer standalone apps with ember-cli
MIT License
21 stars 31 forks source link

Enable TypeScript strict mode #136

Closed tomdale closed 6 years ago

tomdale commented 6 years ago

This commit enables TypeScript's strict mode: no implicit any, strict null checks, etc.

As part of this work, I also removed all use of raw require() and switched to TypeScript's import = require() syntax, which preserves type information. Since many dependencies don't have type definitions, I manually annotated the subset of API we rely on in the typings.d.ts file.

Turbo87 commented 6 years ago

+2,758 −1,045

to be honest I'm not sure how to review this in a reasonable way given that it is all in a single commit 🤔

locks commented 6 years ago

@Turbo87 most of the changes (>2000) seem to be in the lockfile, so I'd just trust Yarn on that file 👼. Need some more time for glimmer-app.ts, rest seems 👍