search

glimmerjs / glimmer-application-pipeline

Tooling for developing Glimmer standalone apps with ember-cli
MIT License
21 stars 31 forks source link

[ Fix #146 ] move addonProcessTree to the correct position #150

Closed tschoartschi closed 6 years ago

tschoartschi commented 6 years ago

so that postprocessTree fires after everything is finished

This fixes #146 and now fingerprinting of public files works again

rondale-sc commented 6 years ago

@tschoartschi Seems like this failure you are seeing is present on master branch as well.

tschoartschi commented 6 years ago

@rondale-sc @rwjblue it seems like the following line in @types/babel-traverse/index.d.ts: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c972d79/types/babel-traverse/index.d.ts#L348 is not compatible with the TypeScript version specified in our package.json. I tried it with TypeScript 2.9.2 (because I have it locally installed in another project) and it worked after adding "skipLibCheck": true to tsconfig.json. So not sure how to go on from this point. Let me know what your thoughts are.

rondale-sc commented 6 years ago

@tschoartschi Does the test suite pass when you upgrade the typescript version and add the skipLibCheck?

If so, I'd imagine it is relatively safe to bump and release.

/cc @rwjblue

rwjblue commented 6 years ago

Thank you @tschoartschi and @rondale-sc!