Remove linting trees from build

glimmerjs / glimmer-application-pipeline

Tooling for developing Glimmer standalone apps with ember-cli

MIT License

21 stars 31 forks source link

Remove linting trees from build #153

Closed rondale-sc closed 5 years ago

rondale-sc commented 5 years ago

This was posed as an RFC to ember-cli and merged (but not implemented. The idea is that we have standard ways to lint and it complicates (and slows) our build, so add an yarn test command that includes ember test && yarn run lint:js && yarn run lint:template

For reference the RFC is here:

https://github.com/sangm/rfcs/blob/master/active/0000-remove-ember-cli-eslint.md

rondale-sc commented 5 years ago

This PR necessitates changes to the blueprint in glimmer.js repo. Those changes need to be:

[ ] to include the eslint and ember-template-lint packages as dev dependencies
[ ] to add package.json scripts to run:
- lint:js -> eslint .
- lint:template -> ember-template-lint .
- Have yarn test -> ember test && yarn run lint:js && yarn run lint:template

rondale-sc commented 5 years ago

@rwjblue I think likely this is a breaking change. Users will need to lint on their own. New blueprinted applications won't be a problem, but existing users will need to know to expect a change.