glimmerjs / glimmer-application

[MOVED] This package is now part of the Glimmer.js monorepo
https://github.com/glimmerjs/glimmer.js
30 stars 13 forks source link

Argument and property naming conflict #80

Closed kellyselden closed 6 years ago

kellyselden commented 7 years ago

First of all, don't know if this is the right place.

Given:

<list-component @incoming="Kelly" />
import Component from '@glimmer/component';

export default class ListComponent extends Component {
  incoming = "Selden"
};
{{@incoming}} {{incoming}}

I get "Kelly" with no errors in the console. If I change one of them to "incoming2", I get the expected "Kelly Selden". Reading about the distinction between arguments and properties, it seems like you should be able to reuse a name and not conflict.

locks commented 7 years ago

I can't reproduce @kellyselden, can you add your package.json?

kellyselden commented 7 years ago
  "devDependencies": {
    "@glimmer/application": "^0.6.0",
    "@glimmer/application-pipeline": "^0.7.3",
    "@glimmer/blueprint": "^0.4.0",
    "@glimmer/resolver": "^0.3.0",
    "broccoli-asset-rev": "^2.5.0",
    "ember-cli": "^2.14.0-beta.2",
    "ember-cli-inject-live-reload": "^1.6.1",
    "ember-cli-sass": "^6.2.0",
    "ember-cli-uglify": "^1.2.0",
    "typescript": "^2.2.2"
  }
pittst3r commented 7 years ago

Looks like there's a @glimmer/compiler mismatch. @glimmer/application has 0.25.1 and @glimmer/application-pipeline -> ember-build-utilities has 0.24.0-beta.4. I have a PR addressing this (https://github.com/ember-cli/ember-build-utilities/pull/18). This could be the cause of the problem.

pittst3r commented 7 years ago

Nah, that's probably not the problem here.

tomdale commented 6 years ago

Seems to be working for me too. Playground repro

locks commented 6 years ago

@kellyselden I'm closing this due to lack of reproduction. Please ping me and reopen if you still find it a problem 🙏

kellyselden commented 6 years ago

Just verified not a problem. I can't even reproduce the original failure :man_shrugging: