glimmerjs / glimmer-blueprint

[MOVED] This package is now part of the Glimmer.js monorepo
https://github.com/glimmerjs/glimmer.js
25 stars 13 forks source link

Do not include yarn.lock in upgrades #53

Closed t-sauer closed 7 years ago

t-sauer commented 7 years ago

Right now yarn.lock is included in upgrades done via ember init. This is pretty unnecessary since the file is empty anyway and if you try to look at the diff it will take a couple of seconds.

@rwjblue suggested to check if a non empty yarn.lock file already exists, but in my opinion this could be annoying if you don't want to use yarn since the lockfile will appear again after every upgrade.

So for now I check if project.pkg.name is set which is the case for ember init in existing projects, but not for ember new or ember init in empty folders.

rwjblue commented 7 years ago

Thank you!