search

glimmerjs / glimmer-vm

MIT License
1.13k stars 190 forks source link

License metadata for v0.85 packages is missing #1463

Closed davidtaylorhq closed 4 months ago

davidtaylorhq commented 9 months ago

We use licensee to check license compatibility of all our dependencies in Discourse. The recent 0.85 version bump of glimmer packages is causing licensee checks to fail on @glimmer/syntax and @glimmer/interfaces because it is unable to find valid version Metadata.

This is also evident on NPM, where v0.84.3 correctly shows "License: MIT", while v0.85.3 shows "License: none".

I'm not sure what has changed here. It doesn't look like the 0.84.3 package.json files had a license key either... so something (related to the release process?) must have been magically inserting the license metadata in the past. 🤔

NullVoxPopuli commented 9 months ago

Thanks for opening this issue! The vm repo has had a toooon of infra changes since 0.84.3, so that's probably an explanation..

Will fix, thanks!

andreyfel commented 5 months ago

Experiencing the same issue. Maybe an easy fix for that could be to add a license field to all packages' package.json files?

NullVoxPopuli commented 5 months ago

sounds reasonable to me! sorry I haven't gotten to this. doing too many things :sweat_smile:

andreyfel commented 4 months ago

https://github.com/glimmerjs/glimmer-vm/pull/1579