glimmerjs / glimmer-vm

MIT License
1.13k stars 191 forks source link

Updating tracked variables throws an exception when the receiving element is in a pictureinpicture window #1595

Open deanylev opened 3 months ago

deanylev commented 3 months ago

Due to this check: https://github.com/glimmerjs/glimmer-vm/blob/10eae7429b702b1e7f5434b91802d5767ff7ad9a/packages/%40glimmer/util/lib/simple-cast.ts#L85 while appending an element like this and then updating a tracked variable it relies on.

Wondering why that check exists in the first place, and whether we can make it a bit more robust to allow this case.

In my project I have simply patched out this line and it seems to work just fine.