search

glimmerjs / glimmer-vm

MIT License
1.13k stars 191 forks source link

Explore performance #1596

Closed NullVoxPopuli closed 2 months ago

NullVoxPopuli commented 3 months ago

The goal of this PR is to try to see if we can undo the perf losses reported by

github-actions[bot] commented 3 months ago

duration phase estimated regression +95ms [30ms to 161ms] OR +0.64% [0.2% to 1.09%] renderEnd phase no difference [-2ms to 1ms] render1000Items1End phase no difference [-11ms to 6ms] clearItems1End phase no difference [-1ms to 6ms] render1000Items2End phase no difference [-10ms to 7ms] clearItems2End phase no difference [-1ms to 5ms] render5000Items1End phase no difference [-9ms to 48ms] clearManyItems1End phase estimated improvement -2ms [-6ms to 0ms] OR -1.02% [-2.6% to -0.16%] render5000Items2End phase estimated regression +47ms [15ms to 79ms] OR +1.24% [0.41% to 2.08%] clearManyItems2End phase no difference [-3ms to 1ms] render1000Items3End phase estimated regression +15ms [1ms to 28ms] OR +1.99% [0.11% to 3.64%] append1000Items1End phase estimated regression +15ms [4ms to 26ms] OR +1.72% [0.43% to 3.01%] append1000Items2End phase no difference [-16ms to 16ms] updateEvery10thItem1End phase no difference [-5ms to 6ms] updateEvery10thItem2End phase no difference [-1ms to 2ms] selectFirstRow1End phase no difference [-1ms to 0ms] selectSecondRow1End phase no difference [-2ms to 1ms] removeFirstRow1End phase no difference [0ms to 1ms] removeSecondRow1End phase no difference [-1ms to 0ms] swapRows1End phase no difference [-1ms to 0ms] swapRows2End phase no difference [0ms to 0ms] clearItems4End phase no difference [-2ms to 4ms] paint phase no difference [0ms to 0ms]

[22:23:02] Generating Benchmark Reports [started] [22:23:07] Generating Benchmark Reports [completed]

Benchmark Reports

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

NullVoxPopuli commented 2 months ago

Closing, because https://github.com/glimmerjs/glimmer-vm/pull/1606 solved a lot