it would likely be too accidentally disruptive to switch to using real glimmer packages in a patch release
ember-source's deps should instead use the correct glimmer (and we wshould confirm this)
[ ] debug code is ending up in production (even in 0.84.3)
[ ] if any debug things that weren't present in 0.84.3 should be changed to LOCAL_DEBUG
[ ] are there any DEBUG things that are not for ember-debug?
[x] dead code elimination of the GlimmerVM
[x] all "checks" code should not make it to production builds
All the @glimmer/debug stack-checks are in the prod build
This is most of what was added post-0.84.3 -- making debugging experience better / making working in the VM easier about what's going on.
Original Issue: https://github.com/glimmerjs/glimmer-vm/issues/1590
As a part of this issue, it was reported that, in consuming ember.js apps, the vendor.js (where the VM lives), grew by ~ 50KB. See: https://github.com/emberjs/ember.js/issues/20628
Suspicions to investigate
we need embroider and auto-import to use the real@glimmer/*dependencies and not theember-source/dist/dependenciesstuff@glimmer/debugstack-checks are in the prod build This is most of what was added post-0.84.3 -- making debugging experience better / making working in the VM easier about what's going on.Things that don't work
No change in perf
Things that have a small improvement
Needs further exploration
Use terser in the development -- shrinks the build in dev by 3kb
More aggressive build / rollup changes Dev shrinks by ~ 17KB, Prod shrinks by ~ 7KB
[ ] Using the production assets as the development assets https://github.com/glimmerjs/glimmer-vm/pull/1599
Notes
Which packages are in ember-source?