glimmerjs / glimmer-vm

MIT License
1.13k stars 191 forks source link

Backtracking re-render during lazy initialization #1632

Closed NullVoxPopuli closed 1 month ago

NullVoxPopuli commented 1 month ago

Issue:

github-actions[bot] commented 1 month ago

duration phase no difference [-127ms to 84ms] renderEnd phase no difference [-1ms to 2ms] render1000Items1End phase no difference [-2ms to 18ms] clearItems1End phase no difference [-2ms to 4ms] render1000Items2End phase no difference [-7ms to 13ms] clearItems2End phase no difference [0ms to 1ms] render5000Items1End phase no difference [-20ms to 30ms] clearManyItems1End phase no difference [-2ms to 3ms] render5000Items2End phase no difference [-39ms to 35ms] clearManyItems2End phase no difference [-3ms to 1ms] render1000Items3End phase no difference [-18ms to 17ms] append1000Items1End phase no difference [-38ms to 19ms] append1000Items2End phase no difference [-16ms to 3ms] updateEvery10thItem1End phase no difference [-1ms to 0ms] updateEvery10thItem2End phase no difference [-14ms to 0ms] selectFirstRow1End phase no difference [0ms to 0ms] selectSecondRow1End phase no difference [0ms to 0ms] removeFirstRow1End phase no difference [-1ms to 1ms] removeSecondRow1End phase no difference [-1ms to 0ms] swapRows1End phase no difference [-1ms to 0ms] swapRows2End phase no difference [-1ms to 0ms] clearItems4End phase no difference [-2ms to 1ms] paint phase no difference [0ms to 0ms]

[20:43:56] Generating Benchmark Reports [started] [20:44:05] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

NullVoxPopuli commented 1 month ago

This isn't a reproduction as errors manifest on older VM versions