search

glimmerjs / glimmer-web-component

Library to boot up your Glimmer components as Web Components
https://glimmerjs.com/guides/using-glimmer-as-web-components
MIT License
30 stars 11 forks source link

Fix type error #10

Closed pittst3r closed 7 years ago

pittst3r commented 7 years ago

Addresses #9. @glimmer/application was being installed as a nested dependency because the blueprint installed @glimmer/application@0.4.0 and @glimmer/web-component@0.3.10:

$ npm ls @glimmer/application
hello-wc@0.0.0 /Users/rpitts/repos/personal/hello-wc
├── @glimmer/application@0.4.0
├─┬ @glimmer/component@0.3.9
│ └── @glimmer/application@0.3.10
└─┬ @glimmer/web-component@0.1.0
  └── @glimmer/application@0.3.10

This resulted in two different versions of Environment to be used, causing the type error.

This PR goes beyond upgrading @glimmer/application and moves it to devDependencies. We should not be seeing @glimmer/application inside node_modules/@glimmer/web-component/node_modules now.

dgeb commented 7 years ago

Good catch @robbiepitts - I was just about to dig into #9 myself 👍