search

glimmerjs / glimmer.js

Central repository for the Glimmer.js project
https://glimmerjs.com
MIT License
751 stars 75 forks source link

I'd like Unit Tests instead of Integration Tests #28

Closed forbesmyester closed 2 years ago

forbesmyester commented 6 years ago

I understand that having a few integration tests through the browser is desirable, but am not at all sure they should be ran on npm test.

Standard unit tests are faster, easier to debug and have a far better developer experience. I think we should consider having them out of the box instead of integration tests which probably won't due to individual workstation configuration.

Failing that easily find-able instructions on how to switch.

rwjblue commented 6 years ago

Sadly the words "unit test" and "integration test" have fairly little meaning (or rather they mean many different things to different people). Can you describe the type of test you are trying to write (possibly pseudo code)?

forbesmyester commented 6 years ago

That is true.

I want to write most of my tests so that they run without any side effects and do not depend on any external state, they should run in as short a time as possible and should not steal the focus (as in window which is active) away from my editor. These tests also tend to be super easier to write and tend to make more of the app stateless and therefore easier to maintain in future.

Later on I would probably write what I would call integration tests (that test through the browser and interact with real databases) but not as a first port of call.

Thanks

On 27 Oct 2017 9:00 pm, "Robert Jackson" notifications@github.com wrote:

Sadly the words "unit test" and "integration test" have fairly little meaning (or rather they mean many different things to different people). Can you describe the type of test you are trying to write (possibly pseudo code)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glimmerjs/glimmer.js/issues/28#issuecomment-340071189, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT1sxmn-J9YWiufxQSKlYy3LnfqvBCNks5swjZBgaJpZM4P94Ax .

locks commented 2 years ago

Thanks for the original discussion! I'm closing this issue as the library is sort on hiatus. I suggest giving https://github.com/glimmerjs/glimmer-experimental/ a try if you're looking for an alternative.