glimmerjs / resolution-map-builder

MIT License
4 stars 7 forks source link

Unresolvable types #26

Closed pittst3r closed 7 years ago

pittst3r commented 7 years ago

Test tells the story.

rwjblue commented 7 years ago

Can you confirm what happens when getModuleSpecifier returns null? I presume that there just isn't an entry in the returned map, but wanted to confirm...

pittst3r commented 7 years ago

@rwjblue This is the same thing that we return when the collection is unresolvable. Yes, you are correct, when building the map we check for the truthiness of the value returned by getModuleSpecifier before adding an entry.

rwjblue commented 7 years ago

Released as 0.5.1