search

glimpseio / glacier

https://glimpseio.github.io/glacier/
MIT License
0 stars 1 forks source link

Factor encoding out into channel actions #85

Closed weswigham closed 7 years ago

weswigham commented 7 years ago

I spoke about this on Thursday, but this is necessary to 1. make the encoding interface easier to consume, and 2. allow joined fields to be easily referenced (using their field id) without leaking implementation details. This also includes much more of the encoding object's actual types (some out of necessity, some out of a desire for completeness).

@Omodi You did the original encoding work, you should look through this in detail.

A point of potential contention is that right now I still allow fields to be referenced by name - this can be a footgun, as it will break if you start using joins but keep using names, so it is possible that we could remove that convenience and force using field ids all the time to remove the footgun.

weswigham commented 7 years ago

@Omodi please review

weswigham commented 7 years ago

Pulled them off the docs page for Vega lite rather than their code. I'd prefer to pull from their code, but that should happen in the future when their public API is improved anyway.