search

glin / reactable

Interactive data tables for R
https://glin.github.io/reactable
Other
612 stars 79 forks source link

Failing CRAN check on r-devel-linux-x86_64-fedora-clang #308

Closed glin closed 1 year ago

glin commented 1 year ago

Tests currently fail on CRAN for one platform, r-devel-linux-x86_64-fedora-clang: https://cran.r-project.org/web/checks/check_results_reactable.html

checking tests ... [12s/58s] ERROR Running ‘testthat.R’ [12s/57s] Running the tests in ‘tests/testthat.R’ failed. Complete output:

library(testthat) library(reactable)

test_check("reactable") free(): double free detected in tcache 2

The original failure was in version 0.4.0, where the Fedora tests failed due to a bug with the V8 system package in Fedora 36 and below, which CRAN uses. This was fixed in the 0.4.1 submission (https://github.com/glin/reactable/commit/029e6c39ed37015bf0786c7e84cc11353594f8f8) - worked around by trying to detect that V8 bug and skip related tests. That fixed the fedora-gcc test failure, but unfortunately, fedora-clang started failing from a new issue that I just have no idea about.

It's hard to test because the R-hub fedora-clang image is on an older version of Fedora (33) than CRAN (36), where the V8 R package doesn't even install. I may end up skipping these tests on CRAN completely. Sorry if you've received this message from CRAN,

We have asked for an update fixing the check problems shown at https://cran.r-project.org/web/checks/check_results_reactable.html with no update from the maintainer thus far.

Thus, package reactable is now scheduled for archival on 2023-01-20, and archiving this will necessitate also archiving its CRAN strong reverse dependencies.

glin commented 1 year ago

Now hopefully fixed in https://github.com/glin/reactable/commit/9c067a5070f03c9fcd5d8ce5fd1274691b08c9a4, and submitted to CRAN as v0.4.3

glin commented 1 year ago

Now fixed with the 0.4.3 release, and CRAN checks are now passing: https://cran.r-project.org/web/checks/check_results_reactable.html