Open rosslo opened 3 years ago
Question:
Concern:
styled
is not trackable by jscodeshift
.
- Should we build a tool/ script to find the use of an Aries component with a given property? I think I could adapt my tool for counting the usages of the code units for this quite easily.
I think @deprecated
is the way to go. We just have to make it sufficiently visible that a code unit it going to be removed. That way we prevent new usages. And then we can replace the old usages.
Why: As we are doing design sync stuff, we will have to change the style or behavior which might cause a breaking change.
How: For any potential breaking change, before we merge the change into v4, we should
console.warning
to warn the developer about the legacy props.@deprecated
tag so the other developers can easily be aware of it from IDE.So the breaking changes won't break the production or block the other features and we won't be forced to migrate it on the projects asap.
After we migrate the breaking change on projects and merge the branch into staging, we can start to remove the legacy codes on glints-aries.
Example: The two examples below both blocked the other features release before because we didn't make the change be backward compatible.
Color:
src/Utils/Colors.ts
.TextField:
TextField
got totally redesigned.TextInput
according to the design guideline.TextField
storybook about this component that has been deprecated from the design system and what is the alternative.TextField
: BecauseTextField
is still used at many places and probably has feature or bug request in the future. Therefore, we should still maintain theTextField
inglints-aries
.