gliscowo / isometric-renders

Creates high-resolution isometric screenshots of Minecraft's game objects
https://modrinth.com/mod/isometric-renders
MIT License
109 stars 13 forks source link

[Feature Request] Area synchronization with WorldEdit selection #76

Open DaniDipp opened 1 year ago

DaniDipp commented 1 year ago

It would be great if the mod could listen to WorldEdit's CUI events and update the area selection based on the current WE selection. This would make it easier to make precise adjustments, and allow the (optional) use of the WE selection tool, which many people are already familiar with.

Related: WorldEditCUI mod

gliscowo commented 1 year ago

I am genuinely somewhat confused where the real value with this originates. While I can appreciate that it's potentially redundant to manage two separate selection boxes, I don't see why you would want them to match up either. Both of these tools serve fundamentally different purposes and in my experience you update your WorldEdit selection much more frequently than the Isometric one as you make edits and then only select the final result for rendering once or twice.

I'd appreciate some concrete examples of when this is useful (and how often this would occur), because it's not impossible there are usage patterns where this genuinely makes sense that I'm not aware of

Cheers

DaniDipp commented 1 year ago

Thank you for the reply, it made me realize that I didn't fully think this through, originally. Since I have WorldEditCUI installed on my setup, I already have a selection box in my world for that, and if the two were synchronized, they would just overlap, reducing screen clutter and making it easier (for me, who is very familiar with worldedit selections) to adjust the bounding box.

What I did not consider is that people without WorldEditCUI would just see the isometric-renders selection bouncing around with their WE actions, which is obviously not intended, especially if they already framed the area that they want to render already and are making just a few last adjustments with WE.

My updated suggestion to consolidate these thoughts is that rather than synchronizing the two fundamentally different areas, there could be a subcommand like /isorender area worldedit which would be similar to /isorender area x1 y1 z1 x2 y2 z2, but ask WorldEdit (if available) for the current bounding box instead. This would give users the flexibility of the WorldEdit selection if they want it, while also leaving the two area selections separate for their specific purposes. I also imagine that it would be easier to implement ^^

gliscowo commented 1 year ago

I do agree that having the option to copy the selection from WorldEdit when appropriate could be useful, I'll look into implementing it once I get the time

Cheers

jokil123 commented 7 months ago

The real value of this proposal is the non cuboid selections in WorldEdit. When trying to render parts of a larger structure, the cuboid selection often lacks the fine grain control the poly selection offers for example.