search

gliscowo / isometric-renders

Creates high-resolution isometric screenshots of Minecraft's game objects
https://modrinth.com/mod/isometric-renders
MIT License
109 stars 13 forks source link

Incompatibility with ModernFix mod #82

Closed tunaflsh closed 9 months ago

tunaflsh commented 10 months ago

When running /isorender area and waiting some time inside the GUI, game crashes.

latest.log hs_err_pid58640.log

embeddedt commented 10 months ago

@gliscowo Does Isometric Renders do anything special with regards to freeing buffer builders? The crash appears to be caused by my buffer builder leak workaround

@tunaflsh Try setting mixin.bugfix.buffer_builder_leak=false in the ModernFix config and see if the crash is resolved.

BasiqueEvangelist commented 10 months ago

@‍gliscоwo Does Isometric Renders do anything special with regards to freeing buffer builders? The crash appears to be caused by my buffer builder leak workaround

https://github.com/gliscowo/worldmesher/blob/1.20/src/main/java/io/wispforest/worldmesher/WorldMesh.java#L395-L397

embeddedt commented 10 months ago

This is problematic, as it does not set the buffer reference to null after freeing it, so my fix does not know to skip freeing the buffer itself.

gliscowo commented 10 months ago

I've published a new WorldMesher build which clears the buffer reference - an update for Isometric should follow in the coming days

Cheers

embeddedt commented 10 months ago

Thanks!

gliscowo commented 9 months ago

Well that one sadly ended up taking a whole lot longer than I planned, but I finally got around to actually doing it. 0.4.6 now has the new WorldMesher version in it - which should fix the problem

Cheers

Xplodin commented 3 months ago

seems broken still on 1.20.1. The 0.4.6 build will not load on my instance and complains about 1.20.2 being needed despite it showing 1.20.1 on CF image

Maybe an oversight idk. Trying the modernfix config change now