search

glitch-soc / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
688 stars 184 forks source link

Reply to local only toot kept local #1123

Open vibhi19 opened 5 years ago

vibhi19 commented 5 years ago

As only Glitch Flavor can create the local only toots as local only but user on vanilla dont, so reply to those local only toot federate, its better to set reply also as local only by defulat, no matter if one using vanilla or glitch.

ClearlyClaire commented 5 years ago

This one is tricky. Local-only toots are currently identified using a special emoji at the end of the toot. Implementing your change would mean that it wouldn't be possible for someone to reply non-locally to a local-only toot anymore.

I've been wanting to move away from the emoji thing for a while (see https://github.com/glitch-soc/mastodon/pull/502) but that would make the whole feature unavailable to people not using the glitch-soc web UI…

vibhi19 commented 5 years ago

I didn't done a good job of putting my words, I wanted to say that if i created a local only toot reply to that toot will also be kept as local toot but as of now Vanilla users toot doesn't work as local only it shows as public toot and it federate.

ClearlyClaire commented 5 years ago

I understood that. What I mean is, the glitch-soc flavour tells the backend the toot is a local-only one by adding an eye emoji at the end of the toot. This is the way the backend knows about it. So you can have local-only replies from vanilla (or other clients) by manually adding that emoji.

If I change the behavior to make replies to local-only toots local-only regardless of the presence of an emoji, there are two drawbacks:

  1. Users not using the glitch flavor cannot tell if a toot is local-only or not anymore at a glance
  2. You won't be able to have non-local-only replies to local-only toots anymore even if you want to
vibhi19 commented 5 years ago

@ThibG I found an solution that is much better than current solution

https://github.com/tootsuite/mastodon/pull/8427

Take a look, it add support in vanilla too and we can say good bye to eye for love of god

ClearlyClaire commented 5 years ago

Adding support to vanilla makes it not-vanilla anymore :thinking:

Apart from the vanilla changes, this is exactly what I discussed earlier, and the downsides remain: nothing but glitch-soc's WebUI will be able to tell what is a local-only toot and what isn't, or decide if a toot should be local-only or not.

vibhi19 commented 5 years ago

Adding support to vanilla makes it not-vanilla anymore thinking

its not a big change that will effect overall experience for vanilla user and people move to glitch for more feature not to stick with that old crap.

Apart from the vanilla changes, this is exactly what I discussed earlier, and the downsides remain: nothing but glitch-soc's WebUI will be able to tell what is a local-only toot and what isn't, or decide if a toot should be local-only or not.

hmm i get it right now people using app/vanilla will dont have any idea that toot is local only or not, but accepting this https://github.com/tootsuite/mastodon/pull/8427 well atleast vanilla web ui user know that the toot is local only or not.

You won't be able to have non-local-only replies to local-only toots anymore even if you want to

And i dont see any point of non-local replies in local toots , Local toots should be limited to that instance .if we treat all replies to local only toots, as local only we can ditch eye emoji.

although tell me use case of having non local reply to local only toots.

vibhi19 commented 5 years ago

@ThibG We forked Glitch, it was a bad idea but we did. so i wanted to ask you that can we merge https://github.com/tootsuite/mastodon/pull/8427 this pull request into glitch?

or it is going to create some issue?

ClearlyClaire commented 5 years ago

You could merge #502 which I just updated, and if you want to update the vanilla flavour as well, you could indeed select the front-end parts from the PR you linked, but only the front-end parts.