search

glitch-soc / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
683 stars 181 forks source link

Don't remove extra images or videos from other instances #1975

Open Freeplayg opened 1 year ago

Freeplayg commented 1 year ago

Pitch

Allow posts that have more than 4 images to be shown.

Someone suggested for the the fourth square to include a sub-grid (with a max of 4), with an overlay showing the amount of more images there are. And then users can see the rest by scrolling through the image popup.

Another way of showing this in the UI could be to have the images scroll horizontally. Something like this, but with an arrow button to scroll image

Motivation

For example, Pixelfed (and some other platforms) lets users add more than 4 images. But people on Mastodon will only see the first 4, creating a disconnect.

(issue copied from https://github.com/mastodon/mastodon/issues/19454)

kescherCode commented 1 year ago

This is currently on my bucket list as a configurable instance wide limit.

The ruby code for this requires not a lot of modification. However, the UI does, since you need to both tell a user "there's more than four images here" and a way to actually view thumbnails for all of them (the "fullscreen" view would not be an issue, as that requires little to no changes as far as I know).

Freeplayg commented 7 months ago

I've found that Mastodon also removes extra videos, it is currently capped at just one.

ShadowJonathan commented 5 months ago

Mentioning https://github.com/mastodon/mastodon/issues/14336 since that is the new issue.

Does anyone have a patch they could merge in?

ShadowJonathan commented 5 months ago

@sinoru, since you have a fork (as you mentioned in the above thread), do you want to merge in a patch that ups the limit from 4 to 32?

Also, if you have a patch that alters the frontend (something similar to what freeplay shows), or if you know something that does, that'd be amazing.

cc @TheEssem since I vaguely remember chuckya having this, or something adjacent to it.

sinoru commented 4 months ago

@ShadowJonathan I change it hard coded, So It should be some nicer implementation required. (Limit can be changed by instance)

I can try some thing like: https://github.com/mastodon/mastodon/pull/27833 But, G doesn't like it.

ShadowJonathan commented 4 months ago

This is why I'm suggesting to make that PR to the glitch-soc fork, gargon won't add it, but maybe Claire would like it for glitch-soc

sinoru commented 4 months ago

@ShadowJonathan Okay. I will try in this week.

sinoru commented 4 months ago

@ShadowJonathan I created the PR for this.

ShadowJonathan commented 4 months ago

Thank you, the maintainer is a bit busy at the moment, but i'm pretty sure it will be considered eventually :)