glitch-soc / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
690 stars 184 forks source link

Clicking avatars on profiles in last column doesn't open profile in new tab #245

Closed Cassolotl closed 6 years ago

Cassolotl commented 6 years ago

This bit!

screen shot 2017-12-07 at 22 16 23

When I click a big avatar in that column, nothing happens. I'm used to it opening a profile in a new tab, and can't find any other way of opening a profile in a tab now. :S


hannahwhy commented 6 years ago

It looks like https://github.com/glitch-soc/mastodon/blob/master/app/javascript/flavours/glitch/features/account/components/header.js is missing the <a> wrapping the avatar that's present in vanilla: https://github.com/glitch-soc/mastodon/blob/master/app/javascript/mastodon/features/account/components/header.js#L45

I guess we can add something similar to the header component?

marrus-sh commented 6 years ago

Yeah I think when I wrote this I assumed that the <Avatar> component created a link but it looks like that's not the case; wrapping it in an <a> should be sufficient.

We don't need as complicated of code as vanilla since our avatars don't do the round animation, just gotta add the link.