search

glitch-soc / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
685 stars 182 forks source link

Reporting a private message gives 404 error #2452

Open Andre601 opened 9 months ago

Andre601 commented 9 months ago

Steps to reproduce the problem

  1. Report a user through a private message (i.e. for spam)
  2. Make sure the message is included
  3. Try sending report
  4. You get a 404 error

Expected behaviour

The report should've been send with the message either way

Actual behaviour

A 404 error is given

Detailed description

I assume this issue is present in vanilla Mastodon too, but since the instance in question uses this fork, do I first report it here to ensure it isn't a fork issue. I will forward this issue to Mastodon, should it be confirmed to also exist on it.

There seems to be an issue where if you want to report a user using the Report @user dropdown option, it won't work if you include a message that is private (only visible to mentioned users).

The report flow works fine until you actually want to submit it, at which point a 404 error is reported to you. This issue does not appear if you unselect any private message.

The message type was a "Private Mention" according to the Web-UI.

Mastodon instance

blobfox.coffee

Mastodon version

v4.3.0-alpha.0+glitch

Browser name and version

Firefox 118.0.2

Operating system

Windows 10

Technical details

No response

Plastikmensch commented 9 months ago

I'm unable to reproduce this on the main branch. blobfox.coffee seems to run a heavily modified version of glitch-soc though, so the issue is most likely there.

Ember-ruby commented 9 months ago

I'm unable to reproduce this on the main branch. blobfox.coffee seems to run a heavily modified version of glitch-soc though, so the issue is most likely there.

it's not particularly heavily modified, just the reactions PR and a couple of minor tweaks

Plastikmensch commented 9 months ago

I'm unable to reproduce this on the main branch. blobfox.coffee seems to run a heavily modified version of glitch-soc though, so the issue is most likely there.

it's not particularly heavily modified, just the reactions PR and a couple of minor tweaks

Ah, I just based this on the "x commits ahead, y commits behind" count on the repo linked on the about page. But I just checked again and it seems I looked at the wrong branch facepalm I don't see anything in the 22 commits, which would explain this. A 404 is rather unspecific though. ~Maybe the private mention was already deleted when making the report?~ Is there more information?

Edit: Oh, I was able to reproduce! It seem to happen when the account you want to report is blocking you or is suspended. But it does not explain why this would work when unselecting private mentions.

Ember-ruby commented 9 months ago

Ah, I just based this on the "x commits ahead, y commits behind" count on the repo linked on the about page. But I just checked again and it seems I looked at the wrong branch facepalm

yeah sorry, i hadn't updated the main branch in a bit