glitch-soc / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
702 stars 182 forks source link

Trending Without Review doesn't work for links/statuses #2534

Open TomCasavant opened 10 months ago

TomCasavant commented 10 months ago

Steps to reproduce the problem

  1. docker-compose build the glitch-soc/mastodon repo without modification
  2. Deploy container (in docker)
  3. In Admin discovery settings select "Allow Trends without prior review"
  4. Wait a period of time or manually trigger trends scheduler 4a. I also tried just restarting the server after enabling w/o prior review setting

Expected behaviour

Trending page should fill with unreviewed posts/links

Actual behaviour

Admin trends dashboard show trends waiting for review, trending page remains empty

Detailed description

I'm not sure if this is an intentional behavior within glitch-soc or maybe I am just incorrectly generating the docker image, I assume based on the "Allow Trends without prior review" wording that it's supposed to apply to all types of trends like in vanilla mastodon (it is working for Hashtags which I think was how it was setup in vanilla mastodon at first with a setting for "Allow tags without prior review")

With some experimenting I added this back into app/models/account.rb:

  def trendable?
    boolean_with_default('trendable', Setting.trendable_by_default)
  end

https://github.com/mastodon/mastodon/blob/9251779d755c62dca9326df82687c4b62e2abb8a/app/models/account.rb#L285C1-L287C6

And redeployed which fixed the unreviewed trending statuses, but did not fix the trending links

Mastodon instance

tomkahe.com

Mastodon version

v4.3.0-alpha.0+glitch

Technical details

pietsch commented 2 months ago

This bug is still present in v4.3.0-alpha.5+glitch – in my case, non-Docker. This is a bummer because I don't see the point in moderating trends.

pietsch commented 2 months ago

I can now confirm that the patch included in this bug report resolved the issue for me – https://fedifreu.de/explore is now showing toots and toot authors I have not allowlisted before. (I'm not yet sure about https://fedifreu.de/explore/links – I need more time to observe this.)